Re: [PATCH v2 2/8] serial: txx9: Simplify knowing that .iotype is always UPIO_PORT

[Geert Uytterhoeven]

On Tue, 4 Aug 2026 at 16:05, Atsushi Nemoto <anemo@xxxxxxxxxxxxx> wrote:
> On Tue,  4 Aug 2026 10:57:54 +0200, Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> > After the previous commit it's obvious that .iotype is always UPIO_PORT.
> > Simplify some functions accordingly.
>
> No, .iotype can be UPIO_MEM if early_serial_txx9_setup() was called from
> arch/mips/txx9/generic/setup.c.
>
> Please drop this patch from your series.

Indeed:

    serial_txx9: ttyS0 MMIO:0x0000000fff1ff300 (irq = 32, base_baud =
3125000) is a txx9
    ** 19695 printk messages dropped **
    pcistat:22b0(ReceivedMasterAbort)
    PCIERR interrupt at 0xffffffff80379aec
    [...]

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds