Re: [PATCH 06/39] spi: bcm63xx-hsspi: use modern PM macros

[William Zhang]

On Mon, Aug 3, 2026 at 7:41 AM Jisheng Zhang <jszhang@xxxxxxxxxx> wrote:
>
> Use the modern PM macros for the suspend and resume functions to be
> automatically dropped by the compiler when CONFIG_PM or
> CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.
>
> This has the advantage of always compiling these functions in,
> independently of any Kconfig option. Thanks to that, bugs and other
> regressions are subsequently easier to catch.
>
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---
>  drivers/spi/spi-bcm63xx-hsspi.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
> index 58012e1b5ae7..ca6cf7c19835 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -884,7 +884,6 @@ static void bcm63xx_hsspi_remove(struct platform_device *pdev)
>         sysfs_remove_group(&pdev->dev.kobj, &bcm63xx_hsspi_group);
>  }
>
> -#ifdef CONFIG_PM_SLEEP
>  static int bcm63xx_hsspi_suspend(struct device *dev)
>  {
>         struct spi_controller *host = dev_get_drvdata(dev);
> @@ -919,10 +918,9 @@ static int bcm63xx_hsspi_resume(struct device *dev)
>
>         return 0;
>  }
> -#endif
>
> -static SIMPLE_DEV_PM_OPS(bcm63xx_hsspi_pm_ops, bcm63xx_hsspi_suspend,
> -                        bcm63xx_hsspi_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(bcm63xx_hsspi_pm_ops, bcm63xx_hsspi_suspend,
> +                               bcm63xx_hsspi_resume);
>
>  static const struct of_device_id bcm63xx_hsspi_of_match[] = {
>         { .compatible = "brcm,bcm6328-hsspi", },
> @@ -934,7 +932,7 @@ MODULE_DEVICE_TABLE(of, bcm63xx_hsspi_of_match);
>  static struct platform_driver bcm63xx_hsspi_driver = {
>         .driver = {
>                 .name   = "bcm63xx-hsspi",
> -               .pm     = &bcm63xx_hsspi_pm_ops,
> +               .pm     = pm_sleep_ptr(&bcm63xx_hsspi_pm_ops),
>                 .of_match_table = bcm63xx_hsspi_of_match,
>         },
>         .probe          = bcm63xx_hsspi_probe,
> --
> 2.53.0
>

Acked-by: William Zhang <william.zhang@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature