Re: [PATCH v2] tty: moxa: remove driver.
From: Crescent Hsieh
Date: Tue Aug 04 2026 - 20:29:15 EST
On Tue, Aug 04, 2026 at 03:35:29PM +0200, Greg Kroah-Hartman wrote:
> This is a very old driver, and no known hardware is still around for it,
> and the company says they do not need it anymore, so let's remove it as
> the LLMs are starting to poke at it and find "interesting" things which
> will just waste everyone's time given it's not actually used.
>
> So let's drop it. If someone really needs it, it can come back in the
> future, in a more "modern" way, as the style here is very old...
The removal looks good to me.
Acked-by: Crescent Hsieh <crescentcy.hsieh@xxxxxxxx>
With drivers/tty/moxa.c removed, the following device IDs in
include/linux/pci_ids.h would have no remaining users:
- PCI_DEVICE_ID_MOXA_CP204J
- PCI_DEVICE_ID_MOXA_C218
- PCI_DEVICE_ID_MOXA_C320
Would it make sense to remove them as part of this patch as well?
--
Thanks
Crescent Hsieh