[PATCH 2/2] pinctrl: sx150x: get parent IRQ trigger type from firmware
From: Tsz Shan Chan
Date: Wed Aug 05 2026 - 01:56:11 EST
The driver currently hardcodes the parent interrupt trigger type to
IRQF_TRIGGER_FALLING.
Use the trigger type configured by firmware instead. If no trigger type
is specified, fall back to IRQF_TRIGGER_FALLING to maintain current
behaviour.
Support IRQF_TRIGGER_FALLING and IRQF_TRIGGER_LOW, which match the
sx150x open drain active low interrupt output. Reject unsupported
trigger types.
Signed-off-by: Tsz Shan Chan <tchan@xxxxxxxxxxxxxx>
---
drivers/pinctrl/pinctrl-sx150x.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c
index 015b1d0744e4..62c582a52b3e 100644
--- a/drivers/pinctrl/pinctrl-sx150x.c
+++ b/drivers/pinctrl/pinctrl-sx150x.c
@@ -1125,6 +1125,7 @@ static int sx150x_probe(struct i2c_client *client)
I2C_FUNC_SMBUS_WRITE_WORD_DATA;
struct device *dev = &client->dev;
struct sx150x_pinctrl *pctl;
+ u32 irq_type;
int ret;
if (!i2c_check_functionality(client->adapter, i2c_funcs))
@@ -1224,10 +1225,24 @@ static int sx150x_probe(struct i2c_client *client)
girq->handler = handle_bad_irq;
girq->threaded = true;
+ irq_type = irq_get_trigger_type(client->irq);
+ switch (irq_type) {
+ case IRQF_TRIGGER_FALLING:
+ case IRQF_TRIGGER_LOW:
+ break;
+ case IRQF_TRIGGER_NONE:
+ irq_type = IRQF_TRIGGER_FALLING;
+ break;
+ default:
+ return dev_err_probe(dev, -EINVAL,
+ "unsupported irq trigger type %x\n",
+ irq_type);
+ }
+
ret = devm_request_threaded_irq(dev, client->irq, NULL,
sx150x_irq_thread_fn,
IRQF_ONESHOT | IRQF_SHARED |
- IRQF_TRIGGER_FALLING,
+ irq_type,
client->name, pctl);
if (ret < 0)
return ret;
--
2.55.0