Re: [PATCH v4 10/10] media: microchip-isc: fix WB offset and gain register field masking

[Eugen Hristev]

On 8/3/26 13:20, Balakrishnan Sambath wrote:
> ISC_WB_O_* and ISC_WB_G_* each pack two 13-bit fields. A negative offset
> sign-extends and corrupts the adjacent field. Add masks for the two
> fields and write them with FIELD_PREP(), which masks each value into its
> field, so sign extension can no longer bleed across.
> 
> Fixes: 73c1a577b839 ("media: atmel: atmel-isc: reworked white balance feature")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@xxxxxxxxxxxxx>
> ---


Reviewed-by: Eugen Hristev <ehristev@xxxxxxxxxx>