Re: [PATCH v3 07/15] mm/rmap: track whether the page VMA mapped pgoff is anonymous

[David Hildenbrand (Arm)]

On 8/3/26 16:32, Lorenzo Stoakes (ARM) wrote:
> On Mon, Aug 03, 2026 at 04:02:45PM +0200, David Hildenbrand (Arm) wrote:
>> On 8/3/26 15:51, Lorenzo Stoakes (ARM) wrote:
>>>
>>> As per commit message:
>>>
>>> 	This is laying the groundwork for eventually using anonymous page offsets
>>> 	as the index for all anonymous folios.
>>>
>>> 	No functional change intended.
>>>
>>> I cannot enable an effective change here, because if I did I'd break the kernel
>>> and introduce a bisection hazard.
>>
>> You can just throw in a patch that cleans that up and avoids messing with confusing pgoff?
> 
> You mean do a separate patch for this change?
> 
> The existing code is already very confusing :) it becomes worse with the
> anon stuff added, hence the change.
> 
> I will separate it out assuming this is what you mean?

Right, if the vma_address_end() is not required in this patch (and does not fall
under "track whether the page VMA mapped pgoff is anonymous"), just have it in a
separate cleanup patch "prepare vma_address_end() for further changes" etc.

-- 
Cheers,

David