RE: [Intel-wired-lan] [PATCH iwl-net] ice: clear the default forwarding VSI rule when releasing a VSI

[Romanowski, Rafal]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Petr
> Oros
> Sent: Tuesday, June 23, 2026 12:58 PM
> To: Simon Horman <horms@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; andrew+netdev@xxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Keller, Jacob E <jacob.e.keller@xxxxxxxxx>;
> michal.swiatkowski@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: clear the default forwarding VSI
> rule when releasing a VSI
> 
> 
> On 6/23/26 12:29, Simon Horman wrote:
> > This is an AI-generated review of your patch. The human sending this
> > email has considered the AI review valid, or at least plausible.
> > Full review at: https://sashiko.dev
> > ---
> > ice: clear the default forwarding VSI rule when releasing a VSI
> >
> > This patch restores the cleanup of the default forwarding VSI rule in
> > ice_vsi_release(), clearing it when the VSI owns it. This prevents a
> > rule leak if a trusted VF enters promiscuous mode and is then destroyed.
> >
> >> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c
> >> b/drivers/net/ethernet/intel/ice/ice_lib.c
> >> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
> >> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
> >> @@ -2871,6 +2871,9 @@ int ice_vsi_release(struct ice_vsi *vsi)

Tested-by: Rafal Romanowski <rafal.romanowski@xxxxxxxxx>