Re: [PATCH] block: rnull: use vertical import style

From: Andreas Hindborg

Date: Wed Aug 05 2026 - 07:49:11 EST


"Guru Das Srinagesh" <linux@xxxxxxxxxxx> writes:

> Convert `use` imports to vertical layout for better readability and
> maintainability.
>
> Signed-off-by: Guru Das Srinagesh <linux@xxxxxxxxxxx>
> ---
> Came across a recent commit bc58905eb07 ("samples: rust_misc_device: use
> vertical import style") and found a few more locations that could
> benefit from this cleanup. No functional changes.
>
> Separating out patches per-subsystem as per the review feedback in [0].
>
> Tested via:
>
> $ make LLVM=1 rustfmtcheck || echo "fail"
> $
>
> Initially thought that rust-for-linux/rust-block-next was the right base
> branch to use, which is why I didn't group this with [1] based on
> rust-next that I sent out a short while ago. Using rust-next as base for
> this patch.
>
> [0]: https://lore.kernel.org/lkml/20260628-b4-rust-vertical-imports-v1-0-98bc71d4810b@xxxxxxxxxxx/
> [1]: https://lore.kernel.org/lkml/20260705-rfl-vert-imp-v1-1-2f07946a905f@xxxxxxxxxxx/

I think this patch was already submitted by Alvin back in May [1].

Best regards,
Andreas Hindborg

[1] https://lore.kernel.org/r/20260521-miscdev-use-format-v3-6-56240ca70d0c@xxxxxxxxx