RE: [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078

[Miclaus, Antoniu]

Hi Jonathan,

> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Sunday, August 2, 2026 4:44 AM
> To: Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>
> Cc: Sa, Nuno <Nuno.Sa@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; David Lechner <dlechner@xxxxxxxxxxxx>;
> Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>;
> Conor Dooley <conor+dt@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>;
> Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>; Sabau, Radu bogdan
> <Radu.Sabau@xxxxxxxxxx>; Schmitt, Marcelo
> <Marcelo.Schmitt@xxxxxxxxxx>; Marques, Jorge
> <Jorge.Marques@xxxxxxxxxx>; Salih Erim <salih.erim@xxxxxxx>; Matti
> Vaittinen <mazziesaccount@xxxxxxxxx>; Jishnu Prakash
> <jishnu.prakash@xxxxxxxxxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux
> <linux@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 0/4] iio: adc: ade9000: add support for ADE9078
> 
> [External]
> 
> On Fri, 31 Jul 2026 11:29:46 +0300
> Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> wrote:
> 
> > The ADE9078 is a polyphase energy metering device from the same family as
> > the ADE9000 and is register compatible with it. The main differences
> > relevant to the driver are the absence of the on-chip dip/swell detection,
> > a lower maximum SPI clock (10 MHz), and slightly different full-scale ADC
> > codes.
> 
> This looks fine to me, but will need to sit on list until the dt maintainers
> have gotten to it.  Sashiko did call out some possible preexisting issues
> in the driver.  I haven't looked at them, but if you have some time, it may
> be worth a look the power vs interrupt registration one smells plausible.
> 
Want me to send the fixes in a separate patch or within this series?

> https://urldefense.com/v3/__https://sashiko.dev/*/patchset/20260731082
> 951.1228-1-
> antoniu.miclaus*40analog.com__;IyU!!A3Ni8CS0y2Y!78esTjrnDgvdH9h_Pruv
> IpxZPJggP6_ge3-ecPnYKxN8b32xrwH3oUABtFHCRmEGtnicycd5eqRTn7EkeQ$
> >
> > This series adds support for the ADE9078 to the existing ade9000 driver.
> > It first refactors the driver to move the part-specific values (device
> > name, channel table, and full-scale codes) into a chip_info structure
> > retrieved via device match data, then adds the new device tree compatible
> > and the ADE9078 support itself, and finally updates the documentation.
> >
> > Changes in v2:
> > - move the "respective datasheets" comment wording to avoid churn.
> > - use a generic Kconfig title and list the supported parts.
> > - duplicate the RMS voltage macro instead of a shared base macro.
> >
> > v1: https://urldefense.com/v3/__https://lore.kernel.org/linux-
> iio/__;!!A3Ni8CS0y2Y!78esTjrnDgvdH9h_PruvIpxZPJggP6_ge3-
> ecPnYKxN8b32xrwH3oUABtFHCRmEGtnicycd5eqTALKwajg$ <FILL-IN-v1-
> MESSAGE-ID>/
> >
> > Antoniu Miclaus (4):
> >   iio: adc: ade9000: introduce chip_info structure
> >   dt-bindings: iio: adc: adi,ade9000: add adi,ade9078 compatible
> >   iio: adc: ade9000: add support for ADE9078
> >   docs: iio: ade9000: document ADE9078 support
> >
> >  .../bindings/iio/adc/adi,ade9000.yaml         |  30 ++-
> >  Documentation/iio/ade9000.rst                 |  28 +--
> >  drivers/iio/adc/Kconfig                       |  16 +-
> >  drivers/iio/adc/ade9000.c                     | 180 ++++++++++++------
> >  4 files changed, 175 insertions(+), 79 deletions(-)
> >
> >
> > base-commit: 0b5e142ced4bcf20532da051934bd694d1bbd470