Re: [PATCH v3 6/6] riscv: dts: spacemit: Add CTF2301 on K3 CoM260

[Yixun Lan]

hi Troy,

On 02:00 Wed 05 Aug     , Troy Mitchell wrote:
> Enable I2C6 on the K3 CoM260 module and describe the Sensylink
> CTF2301 temperature sensor and fan controller at address 0x4c.
> 
> Set the I2C6 pin power source in the board-level pinctrl node
> because the IO rail voltage is board-specific.
> 
> Signed-off-by: Troy Mitchell <troy.mitchell@xxxxxxxxx>
> ---
>  arch/riscv/boot/dts/spacemit/k3-com260.dtsi | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k3-com260.dtsi b/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
> index a38d7b738258..95a60fbb411f 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
> @@ -26,6 +26,25 @@ reg_5v_sys: regulator-5v-sys {
>  	};
>  };
>  
..
> +&pinctrl {
> +	i2c6-1-cfg {
I'd prefer to use the reference, keep it short & close to where it's used

 &i2c6_1_cfg

> +		i2c6-1-pins {
> +			power-source = <3300>;
> +		};
> +	};
> +};
> +
> +&i2c6 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c6_1_cfg>;
> +	status = "okay";
> +
> +	temperature-sensor@4c {
> +		compatible = "sensylink,ctf2301";
> +		reg = <0x4c>;
> +	};
> +};
> +
>  &i2c8 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c8_cfg>;
> 
> -- 
> 2.55.0
> 

-- 
Yixun Lan (dlan)