Re: [PATCH RFC v2 2/3] mm: new migrate_mode flag for async using non-temporal stores

[Huang, Ying]

Yiannis Nikolakopoulos <yiannis.nikolakop@xxxxxxxxx> writes:

[snip]

> diff --git a/include/linux/migrate_mode.h b/include/linux/migrate_mode.h
> index 265c4328b36a..f7186e705b48 100644
> --- a/include/linux/migrate_mode.h
> +++ b/include/linux/migrate_mode.h
> @@ -3,6 +3,8 @@
>  #define MIGRATE_MODE_H_INCLUDED
>  /*
>   * MIGRATE_ASYNC means never block
> + * MIGRATE_ASYNC_NON_TEMPORAL_STORES means never block and use non-temporal
> + * stores if supported by the architecture
>   * MIGRATE_SYNC_LIGHT in the current implementation means to allow blocking
>   *	on most operations but not ->writepage as the potential stall time
>   *	is too significant
> @@ -10,10 +12,17 @@
>   */
>  enum migrate_mode {
>  	MIGRATE_ASYNC,
> +	MIGRATE_ASYNC_NON_TEMPORAL_STORES,
>  	MIGRATE_SYNC_LIGHT,
>  	MIGRATE_SYNC,
>  };

Is it better to turn migrate_mode parameter into migrate_flags?

---
Best Regards,
Huang, Ying