Re: [PATCH v3 0/6] iio: light: ltr501: Add ltr329 support

From: Kuppuswamy Sathyanarayanan

Date: Wed Aug 05 2026 - 13:18:38 EST


Hi,

On 8/4/2026 10:02 AM, Esben Haabendal wrote:
> The LiteON LTR-329ALS-01 chip is similar to the LTR-303ALS-01, except for
> interrupt support and related registers, which LTR-329ALS-01 does not have.
>
> Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx>
> ---

Acked-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>


> Changes in v3:
> - Removed duplicated error message on devm_request_threaded_irq() failure.
> - Added Fixes: and Cc: stable tags to fix for error handling of
> devm_request_threaded_irq() failure.
> - Added no_irq_support boolean to simplify checking for chip irq support.
> - Moved check for no_irq_support from ltr501_read_intr_prst() and
> ltr501_write_intr_prst() to callers. Note: event functions are not
> registered for no_irq_support devices.
> - Moved #include <linux/array_size.h> into its place according to
> alphabetical sorting order (although the rest is not really wel sorted).
> - Restored alphanumerical ordering of compatible list in bindings
> documentation.
> - Ordered device arrays and enum values according to alphanumerical sorting
> order.
> - Link to v2: https://patch.msgid.link/20260715-liteon-ltr329-v2-0-d18af55edab5@xxxxxxxxxx
>
> Changes in v2:
> - Fixed error handling when irq is defined for a chip that does not support
> irq, powering the chip down again.
> - Added simlar fix to error handling of devm_request_threaded_irq() error
> handling, powering the chip down again on failure.
> - Added explicit #include <linux/array_size.h>.
> - Link to v1: https://patch.msgid.link/20260715-liteon-ltr329-v1-0-31f027051594@xxxxxxxxxx
>
> To: Jonathan Cameron <jic23@xxxxxxxxxx>
> To: David Lechner <dlechner@xxxxxxxxxxxx>
> To: Nuno Sá <nuno.sa@xxxxxxxxxx>
> To: Andy Shevchenko <andy@xxxxxxxxxx>
> To: Rob Herring <robh@xxxxxxxxxx>
> To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> To: Conor Dooley <conor+dt@xxxxxxxxxx>
> To: Nikita Travkin <nikita@xxxxxxx>
> To: Maslov Dmitry <maslovdmitry@xxxxxxxx>
> To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> Cc: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Cc: linux-iio@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
>
> ---
> Esben Haabendal (6):
> dt-bindings: iio: light: ltr501: Sort compatible enum array
> dt-bindings: iio: light: ltr501: Add missing ltr303 compatible
> dt-bindings: iio: light: ltr501: Add ltr329 compatible
> iio: light: ltr501: Power down chip if request irq fails
> iio: light: ltr501: Add ltr329 driver support
> iio: light: ltr501: Fix sorting order of device arrays
>
> .../bindings/iio/light/liteon,ltr501.yaml | 4 +-
> drivers/iio/light/ltr501.c | 117 +++++++++++++--------
> 2 files changed, 78 insertions(+), 43 deletions(-)
> ---
> base-commit: 075b74841bd0065a3bda3440873c747938e69b68
> change-id: 20260711-liteon-ltr329-a3eb12414866
>
> Best regards,
> --
> Esben Haabendal <esben@xxxxxxxxxx>
>

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer