Re: [PATCH 0/6] Re: [PATCH v1 00/10] platform/x86: msi-wmi-platform: Add fan curves/platform profile/tdp/battery limiting

[Antheas Kapenekakis]

On Tue, 4 Aug 2026 at 00:16, Derek J. Clark <derekjohn.clark@xxxxxxxxx> wrote:
>
> While tesing this series, multiple issues were found that cause crashes
> or compilation warnings. Additionally, since this was first posted, two
> new models have been added that each have a unique feature that must be
> managed before TDP control will be used. Given that Antheas indicated he
> still plans on sending a v2, I'm posting these so they can be
> incorporated in the next version, and so that distro's packaing this out
> of tree can get the fixes and additional functionality in the meantime.
>
> A summary of the changes are as follows:
>
> - Patch 1 detangles a guard with a switch case that violates cleanup
>   rules.
> - Patch 2 removes an unused err variable.
> - Patch 3 teminates the quirk table with a null entry to prevent
>   unquirked platforms from crashing when the driver is loaded.
> - Patch 4 cleans up the device quirk names, fixes a bug with when buffer
>   data is copied as a payload, and adds separate PLx limits as indicated
>   by the windows DLL, if pl1 and pl2 are set to the same minumum it can
>   cause instability.
> - Patch 5 adds support for gen 3, the AMD Strixx version. In order for
>   manual TDP control to funciton the STAPM flag must be toggled off.
> - Patch 6 adds support for the 8 EX Ai+. This device uses a new shift
>   mode, called "manual", to enable TDP adjustment. Since this could
>   conflict with the existing "user" mode, use the quirk table to
>   specifiy which mode is "custom". As a consequence, "custom" must be
>   checked outside of the switch case as it could be one of multiple
>   values.
>
> If you incorporate any of these changes in v2, please add the
> appropriate attribution.
>
> Thanks,
> Derek


Hi,
of course. Its good to have this chain series for anyone that needs it.

I will note that for patch 1 and the missing {} I am aware of those
fixes and implemented them myself to the downstream patch I was
carrying. I never resent a V2 because I did not address Armin's
comments. The missing {} was exposed when Armin fixed the
autodetection. So I cannot attribute those to you. Patch 2 is a review
nit, so after I fix it you can add Reviewed-by. I will make sure for
the last two patches especially to attribute those to you and if
possible keep you as the main author / not add myself if they require
no changes.

I do not have access to my Claw until the middle of August. Once I
have access to it I will have a closer look.

Antheas

> Derek J. Clark (5):
>   platform/x86: msi-wmi-platform: Move guard out of switch in
>     platform_write()
>   platform/x86: msi-wmi-platform: fix: Remove unused err
>   platform/x86: msi-wmi-platform: Clean up devices
>   platform/x86: wmi-msi-platform: Add MSI Claw A8 support
>   platform-x86: msi-wmi-platform: Add Gen 4 device
>
> Matthew Schwartz (1):
>   platform/x86: msi-wmi-platform: terminate msi_quirks DMI table
>
>  drivers/platform/x86/msi-wmi-platform.c | 151 ++++++++++++++++++++----
>  1 file changed, 127 insertions(+), 24 deletions(-)
>
> --
> 2.55.0
>
>