Re: [PATCH] i3c: dw: fix APB clock name

From: Frank Li

Date: Wed Aug 05 2026 - 16:21:17 EST


On Mon, Aug 03, 2026 at 10:02:24PM +0800, Jisheng Zhang wrote:
> The dt-binding doc says the APB clock name is "apb", but the code uses
> "pclk". Since the dt-binding is an ABI, we can only fix this mismatch
> by fixing the code.

i3c: dw: rename "pclk" to "apb" to match dt-binding

Change clock name "pclk" to "apb" to match dt-binding doc. No upstream
device tree sources currently use the "pclk" clock name, so no any backward
compatibility issues.

Not sure what happen when apply patch a0d48ebf39ce. Anyways, thanks for fix
it.

Frank
>
> Fixes: a0d48ebf39ce ("i3c: dw: Add optional apb clock")
> Signed-off-by: Jisheng Zhang <jszhang@xxxxxxxxxx>
> ---
> drivers/i3c/master/dw-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 2f8c0c4683e0..0625587f1527 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1579,7 +1579,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
> if (IS_ERR(master->core_clk))
> return PTR_ERR(master->core_clk);
>
> - master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
> + master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "apb");
> if (IS_ERR(master->pclk))
> return PTR_ERR(master->pclk);
>
> --
> 2.53.0
>