Re: [PATCH 2/2] net: phy: dp83867: support setting output-impedance

[Jakub Kicinski]

On Tue, 04 Aug 2026 14:46:34 +0200 Steffen Trumtrar wrote:
> Currently the dp83867 supports setting the io impedance to minimum,
> maximum, default or a value from a nvmem cell. In situations where there
> is no backend for a nvmem cell, the value can not be set to anything but
> minimum, maximum or default.
> 
> Add support for the ti,output-impedance binding, allowing to specify the
> impedance via the devicetree. The existing boolean bindings for minimum
> and maximum take precedence over this new binding. The nvmem consumer
> still takes lowest precedence.

Compiler says no:

drivers/net/phy/dp83867.c:549:67: error: incompatible pointer types passing 'u8 *' (aka 'unsigned char *') to parameter of type 'u32 *' (aka 'unsigned int *') [-Wincompatible-pointer-types]
  549 |                 } else if (of_property_read_u32(of_node, "ti,output-impedance", &val)) {
      |                                                                                 ^~~~
../include/linux/of.h:1491:17: note: passing argument to parameter 'out_value' here
 1491 |                                        u32 *out_value)
      |                                             ^
1 error generated.
make[6]: *** [../scripts/Makefile.build:289: drivers/net/phy/dp83867.o] Error 1
-- 
pw-bot: cr