Re: [PATCH v2 2/2] media: rcar-isp: Fix VSPX reference leaks

From: Sakari Ailus

Date: Thu Aug 06 2026 - 06:30:40 EST


Hi Jacopo,

On Thu, Aug 06, 2026 at 11:33:50AM +0200, Jacopo Mondi wrote:
> Hello Linmao Li
>
> On Tue, Aug 04, 2026 at 06:24:31PM +0800, Linmao Li wrote:
> > of_parse_phandle() and of_find_device_by_node() both acquire references,
> > but the ISPCORE probe never releases them. The device node reference is
> > leaked immediately, and the VSPX device reference is leaked on probe
> > failures and on driver removal.
> >
> > Drop the node reference once the platform device has been looked up, and
> > release the device reference on the probe error paths and in the remove
> > path.
> >
> > Signed-off-by: Linmao Li <lilinmao@xxxxxxxxxx>
>
> Thanks, looks good to me!
>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx>
>
> Sakari, Hans, should we collect these two patches as fixes for 7.3 ?

I've picked these and pushed these for merging.

--
Sakari Ailus