Re: [PATCH net RESEND] net/mlx5: Use unique names for software steering caches

From: Leon Romanovsky

Date: Thu Aug 06 2026 - 07:20:12 EST


On Tue, Aug 04, 2026 at 02:57:56PM -0700, Jakub Kicinski wrote:
> On Tue, 4 Aug 2026 11:04:55 +0300 Leon Romanovsky wrote:
> > On Mon, Aug 03, 2026 at 06:26:14PM -0700, Jakub Kicinski wrote:
> > > On Fri, 31 Jul 2026 00:02:00 +0300 Tariq Toukan wrote:
> > > > Prefix each cache name with the device name to make it unique.
> > >
> > > Why do we need a per-device kmem_cache?
> > > Isn't the right fix to make this driver-level state?
> >
> > This kmem_cache is required only for software managed steering mode, which is
> > configured per device by mlx5_fs_mode_set(). In general, resources
> > should be allocated only when they are actually needed.
>
> Of course you have to wrap the init in a lock and count users.
> Trivial stuff.

I don't see why we should abandon the simple, architecturally
correct approach of allocating and managing resources where they
belong in favor of a more complex global scheme involving locking
and reference counting.

Thanks