Re: [PATCH 1/2] dt-bindings: dp83867: add binding for output-impedance

[Andrew Lunn]

> +  ti,output-impedance:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      MAC Interface Impedance control to set the programmable output impedance
> +      to a value between minimum (35 ohms) and maximum (70 ohms).

Please could you express this min/max in yaml, so .dts files can be
verified.

>    ti,min-output-impedance:
>      type: boolean
>      description: |
> @@ -53,10 +59,11 @@ properties:
>        MAC Interface Impedance control to set the programmable output impedance
>        to a maximum value (70 ohms).
>        Note: Specifying an io_impedance_ctrl nvmem cell or one of the
> -        ti,min-output-impedance, ti,max-output-impedance properties
> -        are mutually exclusive. If more than one is present, an nvmem
> +        ti,min-output-impedance, ti,max-output-impedance or ti,output-impedance
> +        properties are mutually exclusive. If more than one is present, an nvmem
>          cell takes precedence over ti,max-output-impedance, which in
> -        turn takes precedence over ti,min-output-impedance.
> +        turn takes precedence over ti,min-output-impedance. Both take precedence
> +        over ti,output-impedance.

You should also be able to express this mutual exclusion in yaml.


    Andrew

---
pw-bot: cr