Re: [PATCH v2] KVM: arm64: nv: Keep the shadow S2 MMUs at fixed addresses

[Karl Mehltretter]

On Thu, Aug 06, 2026 at 03:49:35PM +0100, Wei-Lin Chang wrote:
> 
> I felt the commit message needs to be tightened a bit, so I restructured
> it slightly and removed some information I found unneeded. Here is my
> attempt, feel free to use it if you find it better or further improve it:

Hi Wei-Lin,

Thanks for the review! This is clearer, I'll tighten the commit message.

> 
> > +	/* Allocate the fixed-size pointer table once per VM. */
> 
> This comment seems a bit redundant.
> 

Agreed, I will drop it.

> > -	for (int i = kvm->arch.nested_mmus_size; !ret && i < num_mmus; i++)
> > -		ret = init_nested_s2_mmu(kvm, &kvm->arch.nested_mmus[i]);
> > +	write_lock(&kvm->mmu_lock);
> 
> Opportunity to use guard() or scoped_guard() here.
> 

Good point. I seem to forget about guard. I will use it and send v3.

Thanks,
Karl