Re: [PATCH net-next 1/2] net: lan743x: set interrupt moderation timer based on link speed

From: Jakub Kicinski

Date: Thu Aug 06 2026 - 15:15:20 EST


On Mon, 3 Aug 2026 18:18:46 +0530 Dhanushkalyan G wrote:
> Set the moderation timer as a function of the negotiated link speed in
> the MAC link-up path: 64 us at 2.5G, 150 us at 1G, and 330 us at
> 100M/10M. The interrupt-vector-to-timer mapping (INT_MOD_MAP) is static,
> so it stays programmed once at interrupt open; only the timer value
> (INT_MOD_CFG) is updated, from the new lan743x_config_int_mod() helper,
> when the link comes up.

This patch should go away. With patch 2 user can chose the right
coalescing settings for themselves. adaptive coalescing means that
the driver adjusts the coalescing settings based on _traffic_ not
link speed. Please don't (ab)use that for the trivial link speed based
heuristic. There's a library called DIM which implements the dynamic
algo which you can plug into your driver if you want (it even has docs)