Re: [PATCH v2 4/4] iio: dac: ad3530r: add support for AD5710R/AD5711R

[Andy Shevchenko]

On Fri, Jul 24, 2026 at 11:26:59PM +0100, Jonathan Cameron wrote:
> On Tue, 21 Jul 2026 16:47:13 +0800
> Kim Seer Paller <kimseer.paller@xxxxxxxxxx> wrote:

...

> > +static ssize_t ad5710r_get_dac_powerdown(struct iio_dev *indio_dev,
> > +					 uintptr_t private,
> > +					 const struct iio_chan_spec *chan,
> > +					 char *buf)
> > +{
> > +	struct ad3530r_state *st = iio_priv(indio_dev);
> > +	unsigned int reg_offset, ch_in_reg, reg, mode, mask;
> > +	int ret;
> > +
> > +	reg_offset = chan->channel / AD3530R_CH_PER_REG;
> > +	ch_in_reg = chan->channel % AD3530R_CH_PER_REG;
> > +	reg = AD3530R_OUTPUT_OPERATING_MODE_0 + reg_offset;
> > +	mask = AD3530R_OP_MODE_CHAN_MSK(ch_in_reg);
> > +
> > +	ret = regmap_read(st->regmap, reg, &mode);
> > +	if (ret)
> > +		return ret;
> > +
> > +	return sysfs_emit(buf, "%d\n", !!(mode & mask));
> 
> For consistency with the prep below, perhaps field_get() is appropriate here
> rather than !! trickery.

FYI: we have regmap_test_bits().

> > +}

-- 
With Best Regards,
Andy Shevchenko