Re: [PATCH v4 0/2] mm/zswap: Fixes and improves the zswap shrink

[Yosry Ahmed]

On Thu, Aug 6, 2026 at 3:41 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu,  6 Aug 2026 15:09:41 +0800 Hao Jia <jiahao.kernel@xxxxxxxxx> wrote:
>
> > From: Hao Jia <jiahao1@xxxxxxxxxxx>
> >
> > This series fixes and improves the zswap global shrinker (shrink_worker()):
> > Patch 1: Fix missing global shrinker when memory cgroup is disabled.
> > Patch 2: Extend shrink_memcg() to support batch writeback and thereby improving
> >          the writeback efficiency in the shrink_worker() and zswap_store() paths.
>
> Thanks.
>
> Why is a -stable backport proposed for [1/2]?  Its changelog should
> describe the effect of the bug upon our users so that others can
> understand why this was requested.

It's a potential performance regression for people using zswap without
memcg that was introduced by the commit in "Fixes".

>
> AI review suggests there may be an issue in [1/2].  Please check?
>         https://sashiko.dev/#/patchset/20260806070943.95542-1-jiahao.kernel@xxxxxxxxx

Same thing from previous versions, shouldn't be a problem in practice.