Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Document RTC client properties
From: Bjorn Andersson
Date: Thu Aug 06 2026 - 20:03:41 EST
On Fri, Aug 07, 2026 at 02:26:30AM +0530, Kamal Wadhwa wrote:
> The pmic_glink driver can now register an RTC auxiliary device on
> glymur, whose PMIC exposes an RTC over GLINK (see rtc-glink driver).
> Document the allow-set-time flag it consumes from the parent
> pmic-glink node.
The driver functionality has no relevance to the DeviceTree binding.
The binding defines the contract between the DeviceTree (DTB) and the
implementation, such that the implementation knows what to expect from
and how to interpret the DTB.
>
> Assisted-by: Claude:claude-sonnet-5
> Signed-off-by: Raj Aryan <raryan@xxxxxxxxxxxxxxxx>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
As with the driver, the author/s-o-b chain is wrong.
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 16ad4f5698fc..38db1ff473c0 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -79,6 +79,11 @@ properties:
> - const: charge_limit_end
> - const: charge_limit_delta
>
> + allow-set-time:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Indicates that the setting of RTC time is allowed by the host CPU.
What property of the hardware/firmware that this describes would cause
you to set or not set this?
Also, what would the expected outcome be if I declare that my Hamoa
hardware has pmic-glink with allow-set-time?
Regards,
Bjorn
> +
> patternProperties:
> '^connector@\d$':
> $ref: /schemas/connector/usb-connector.yaml#
>
> --
> 2.43.0
>