Re: [PATCH v2] selftests/mm: Drop duplicate test_seal_mprotect_two_vma_with_gap() call

From: SJ Park

Date: Thu Aug 06 2026 - 20:31:43 EST


On Thu, 6 Aug 2026 11:08:50 +0800 Hongfu Li <hongfu.li@xxxxxxxxx> wrote:

> From: Hongfu Li <lihongfu@xxxxxxxxxx>
>
> mseal_test main() invokes test_seal_mprotect_two_vma_with_gap() twice.
> The second run repeats all assertions with no benefit. Drop the
> duplicate call.

Good eyes, thank you for fixing this!

>
> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
> Reviewed-by: Lorenzo Stoakes (ARM) <ljs@xxxxxxxxxx>
> Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

Reviewed-by: SJ Park <sj@xxxxxxxxxx>

> ---
> v2:
> - update ksft_set_plan(88) to 87 to match the actual number of tests
> after removing the duplicate call.

I wonder if there could be an automated way for this. Obviously not a question
to the author but just my loud thought.


Thanks,
SJ

[...]