Re: [PATCH v9 4/6] thermal: khadas-mcu-fan: Add fan config from platform data Add regulator support

From: Daniel Lezcano

Date: Thu Aug 06 2026 - 22:34:44 EST


On 8/5/26 10:06, Ronald Claveau via B4 Relay wrote:
From: Ronald Claveau <linux-kernel-dev@xxxxxxxx>

Replace the hardcoded MAX_LEVEL constant and fan register
with values read from platform_data (fan_reg, levels[] and nlevels),
as new MCUs need different values.

The cooling device's state is stored as an index into levels[],
and khadas_mcu_fan_set_level() writes levels[state] to fan_reg,
rather than writing the raw state value as before.

Optionally acquire and enable a "fan" regulator supply
at probe time and on resume,
so boards that gate fan power through a regulator are handled.

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Signed-off-by: Ronald Claveau <linux-kernel-dev@xxxxxxxx>
---

* Through which tree this patch should go ? (assuming there is a dependency on other patches)

* How this will behave with 100 levels with the step wise governor ? For a 100ms passive delay and 100 states, it will take 10s before reaching the full speed