Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function
From: Greg Kroah-Hartman
Date: Fri Aug 07 2026 - 03:10:59 EST
On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote:
> The return value of this function is ignored at the call site, and since
> the function has no side effects (except for the assignment to
> pHalData->pwrdown, which is not used anywhere else), it can be removed.
>
> At the same time, remove the efuse shadow functions, as they are
> becoming unused.
Why not remove pwrdown first, which shows that it is never actually
used, and then remove the functions in a separate patch? that would
"prove" that this is a safe change, as-is we need to manually verify
this patch is correct.
thanks,
greg k-h