Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function

[Dan Carpenter]

On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote:
> The return value of this function is ignored at the call site, and since
> the function has no side effects (except for the assignment to
> pHalData->pwrdown, which is not used anywhere else), it can be removed.
> 

The patch needs to get rid of pwrdown from include/hal_data.h.  There
are two reasons for this.

1) For correctness and cleanliness.
2) It makes the patch easier to review because as the patch is written
   now we need to check the kernel source to see if what you're saying
   is true.  But if we delete it and it is actually used somewhere then
   we can rely on the kbuild-bot to find the mistake.

regards,
dan carpenter