Re: [PATCH v5 2/6] pinctrl: qcom: Register functions before enabling pinctrl

[Linus Walleij]

On Tue, Aug 4, 2026 at 8:34 AM Alexandre MINETTE via B4 Relay
<devnull+contact.alex-min.fr@xxxxxxxxxx> wrote:


> From: Alexandre MINETTE <contact@xxxxxxxxxxx>
>
> pinctrl consumers can request states while the pinctrl core enables the
> controller. On Qualcomm pinctrl drivers this can happen before the SoC
> function list has been registered, which leaves the function table
> incomplete during state lookup.
>
> On APQ8064 this can fail while claiming pinctrl hogs:
>
>    apq8064-pinctrl 800000.pinctrl: invalid function ps_hold in map table
>    apq8064-pinctrl 800000.pinctrl: error claiming hogs: -22
>    apq8064-pinctrl 800000.pinctrl: could not claim hogs: -22
>
> Register Qualcomm pinctrl with devm_pinctrl_register_and_init(), add the
> SoC pin functions, and only then enable the pinctrl device.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Alexandre MINETTE <contact@xxxxxxxxxxx>

This is for Bartosz to apply independently if he hasn't already.

FWIW
Acked-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij