Re: [PATCH v4] staging: iio: frequency: ad9832/ad9834: add comment explaining do_div usage
From: Joshua Crofts
Date: Fri Aug 07 2026 - 06:25:13 EST
On Fri, 7 Aug 2026 15:17:03 +0530
Mohamad Raizudeen <raizudeen.kerneldev@xxxxxxxxx> wrote:
> Previous attempts to change do_div() to div64_ul were rejected because
> mclk will always fit within 32 fits for this hardware, making do_div()
> safe to use.
>
> However, Coccinelle continues to flag this as a false positive. To
> prevent future developers from submitting unnecessary fixes, add a
> comment explaining why do_div() is intentionally kept.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Signed-off-by: Mohamad Raizudeen <raizudeen.kerneldev@xxxxxxxxx>
> ---
Fine now.
Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
--
Kind regards,
Joshua Crofts