Re: [PATCH 1/3] dt-bindings: Add InvenSense ICM-42370-p accelerometer

From: Kanak Shilledar

Date: Fri Aug 07 2026 - 09:37:43 EST


Hi,

Thanks for reviewing the code.

On Fri, 2026-08-07 at 12:16 +0200, Joshua Crofts wrote:
> [You don't often get email from joshua.crofts1@xxxxxxxxx. Learn why
> this is important at https://aka.ms/LearnAboutSenderIdentification ;]
>
> On Thu, 6 Aug 2026 14:46:27 +0200
> Kanak Shilledar <kanak.shilledar@xxxxxxxx> wrote:
>
> > +  vdd-supply:
> > +    description: Regulator operating range between 1.71V to 3.6V.
> > +
> > +  vddio-supply:
> > +    description: Regulator operating range between 1.71V to 3.6V.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
>
> vdd-supply and vddio-supply are definitely required.

Will add them in the dt-binding as well as other properties suggested
by sashiko.
> ...
>
> > +INVENSENSE ICM-42370P ACCELEROMETER
> > +M:   Kanak Shilledar <kanak.shilledar@xxxxxxxx>
> > +M:   Henrik Grimler <henrik.grimler@xxxxxxxx>
> > +L:   linux-iio@xxxxxxxxxxxxxxx
>
> No need to add the IIO list as get_maintainer will automatically find
> it based on the file path. However I did notice that you have a
> company kernel mailing list, perhaps add that here?

Thanks for pointing that out. We will update it to our company kernel
mailing list (i.e., kernel@xxxxxxxx).

> --
> Kind regards,
> Joshua Crofts

Thanks and Regards,
Kanak Shilledar

Attachment: signature.asc
Description: This is a digitally signed message part