Re: [PATCH 6.12.y 0/2] spi: cadence-quadspi: fix probe error path and remove
From: Greg Kroah-Hartman
Date: Fri Aug 07 2026 - 09:50:18 EST
On Fri, Aug 07, 2026 at 01:49:19PM +0200, Diogo Ivo (Schneider Electric) wrote:
> This series fixes two resource leaks in the cadence-quadspi driver's
> probe error path and remove callback.
>
> Patch 1 fixes an imbalanced pm_runtime_enable()/pm_runtime_disable()
> pair: when probe defers after cqspi_request_mmap_dma(),
> pm_runtime_disable() is called without a prior pm_runtime_enable().
> It also adds the missing pm_runtime_dont_use_autosuspend() in both
> the probe error path and the remove callback and a missing
> pm_runtime_put_noidle() in the probe error path. This consolidates
> fixes from upstream commits 5ff4d5d1af0c and 5e8bb0cc72f1.
>
> Patch 2 fixes a DMA channel leak: when spi_register_controller() fails,
> the channel acquired via cqspi_request_mmap_dma() is never released.
> A dedicated error label is added to release it before the runtime PM
> teardown. This fix is one part of upstream commit f18c8cfa4f1a.
>
> Signed-off-by: Diogo Ivo (Schneider Electric) <diogo.ivo@xxxxxxxxxxx>
> ---
> Diogo Ivo (Schneider Electric) (2):
> spi: cadence-quadspi: fix runtime pm cleanup on probe failure/unbind
> spi: cadence-quadspi: release DMA channel on probe failure
>
> drivers/spi/spi-cadence-quadspi.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
> ---
> base-commit: 7351870f56cba79097a2ab57e609469719ea4f73
> change-id: 20260730-cqspi-pm_runtime-a8a1c6122944
>
> Best regards,
> --
> Diogo Ivo <diogo.ivo@xxxxxxxxxxx>
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>