Re: [PATCH v6 fwctl 0/2] fwctl/bnxt: DMA buffer support for HWRM commands
From: Jason Gunthorpe
Date: Fri Aug 07 2026 - 13:49:55 EST
On Fri, Aug 07, 2026 at 06:28:44PM +0530, Pavan Chebbi wrote:
> Several HWRM (HardWare Resource Manager) commands used for diagnostics,
> firmware management, and NVM access carry one or more DMA address fields
> in their input structures. Until now these commands could not be issued
> through the fwctl interface because the driver had no mechanism to safely
> broker the host-side DMA buffers on userspace's behalf.
>
> This series adds that mechanism in three steps.
>
> In patch #1, the fwctl core UAPI adds a new driver_data field in struct
> fwctl_rpc. Drivers that need a driver_data payload receive the value and
> are free to interpret it. Drivers that do not define one will reject any
> non-zero value with -EOPNOTSUPP. Existing mlx5 and pds fwctl drivers are
> updated accordingly.
>
> In patch #2, the bnxt HSI header is updated to add the missing struct
> definitions for the HWRM commands that the bnxt fwctl driver will support.
>
> In patch #3, the bnxt fwctl driver consumes driver_data as a pointer to
> a new bnxt UAPI struct fwctl_bnxt_driver_data, which describes indirect
> DMA buffers.
> Pavan Chebbi (2):
> bnxt_en: Update bnxt firmware spec
> fwctl/bnxt: add DMA buffer support for HWRM commands
>
> drivers/fwctl/bnxt/main.c | 396 +++++++++++++++++++++++++-
> include/linux/bnxt/hsi.h | 585 ++++++++++++++++++++++++++++++++++++++
> include/uapi/fwctl/bnxt.h | 4 +
> 3 files changed, 980 insertions(+), 5 deletions(-)
Applied to for-next thanks
Jason