Re: [PATCH v1 1/2] perf: RISC-V: use BIT_ULL for u64 overflow masks
From: Paul Walmsley
Date: Fri Aug 07 2026 - 20:47:37 EST
Hi,
On Fri, 7 Aug 2026, Xixin Liu wrote:
> Overflow status and restart masks are u64, but bits were built with
> BIT(). On RV32 that is an unsigned long shift, so indices >= 32 truncate
> or wrap and corrupt the mask.
>
> Use BIT_ULL() for those u64 bitops.
>
> Signed-off-by: Xixin Liu <liuxixin@xxxxxxxxxx>
Thanks for the patch, but, same comments as on
https://lore.kernel.org/linux-riscv/9109b689-1145-c714-ebe0-ec368f242a78@xxxxxxxxxx/T/#m6fa97e46bde0d100fa0ec2854d47a57bd271c0b3
- Paul