Re: [PATCH 4/4] tracing/mmiotrace: Clean up coding style and redundant debug logs

[Google]

On Fri, 7 Aug 2026 20:50:53 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 28 Jul 2026 21:50:19 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > 
> > Clean up coding style issues in trace_mmiotrace.c:
> > - Remove redundant pr_debug() entries in tracer callbacks.
> > - Fix opening brace placement for mmio_tracer.
> > - Prefer 'unsigned int' to bare 'unsigned'.
> > - Add missing blank lines after local variable declarations.
> > 
> > Assisted-by: Antigravity:gemini-3.6-flash
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > ---
> >  kernel/trace/trace_mmiotrace.c |   16 +++++++---------
> >  1 file changed, 7 insertions(+), 9 deletions(-)
> > 
> > diff --git a/kernel/trace/trace_mmiotrace.c b/kernel/trace/trace_mmiotrace.c
> > index 77120d467e11..ce16e1c53d12 100644
> > --- a/kernel/trace/trace_mmiotrace.c
> > +++ b/kernel/trace/trace_mmiotrace.c
> > @@ -36,7 +36,6 @@ static void mmio_reset_data(struct trace_array *tr)
> >  
> >  static int mmio_trace_init(struct trace_array *tr)
> >  {
> > -	pr_debug("in %s\n", __func__);
> 
> So how are these redundant?
> 
> Are there pr_debug() prints elsewhere?

No, that is not redundant, but just like only for debugging mmiotrace.
Maybe we can leave it.

[...]
> > @@ -322,6 +318,7 @@ static void __trace_mmiotrace_rw(struct trace_array *tr,
> >  void mmio_trace_rw(struct mmiotrace_rw *rw)
> >  {
> >  	struct trace_array *tr = mmio_trace_array;
> > +
> >  	__trace_mmiotrace_rw(tr, rw);
> >  }
> >  
> > @@ -353,6 +350,7 @@ static void __trace_mmiotrace_map(struct trace_array *tr,
> >  void mmio_trace_mapping(struct mmiotrace_map *map)
> >  {
> >  	struct trace_array *tr = mmio_trace_array;
> > +
> >  	__trace_mmiotrace_map(tr, map);
> >  }
> 
> Honestly, for one line functions like the above, I think it looks better
> without that blank line.
> 
> -- Steve

Yeah, this is somewhat machinary fix against the checkpatch.pl.
Or, maybe it is better to just pass mmio_trace_array directly?

Thanks,

-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>