Re: [PATCH 03/20] net: xilinx: tsn: add endpoint MAC driver skeleton

[Neeli, Srinivas]

Hi,

On 8/8/2026 2:30 AM, Uwe Kleine-König wrote:
> On Fri, Aug 07, 2026 at 04:14:14PM +0530, Nagadheeraj Rottela wrote:
> > From: Srinivas Neeli <srinivas.neeli@xxxxxxx>
> >
> > The TSN Endpoint MAC owns the IP's host-side MCDMA data path and is the
> > netdev physically wired to the CPU. The DSA switch needs this netdev to
> > exist as its conduit.
> >
> > Add a platform driver (compatible "xlnx,tsn-ep-mac") for the endpoint.
> > Register the netdev named "ep", set its MAC address, and provide minimal
> > netdev and ethtool ops. This skeleton handles device bring-up only, with
> > no data path yet. So ndo_open just starts the queues and ndo_start_xmit
> > drops frames.
> >
> > Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxx>
> > Co-developed-by: Nagadheeraj Rottela <nagadheeraj.rottela@xxxxxxx>
> > Signed-off-by: Nagadheeraj Rottela <nagadheeraj.rottela@xxxxxxx>
> > ---
> >   drivers/net/ethernet/xilinx/tsn/Makefile      |   2 +-
> >   drivers/net/ethernet/xilinx/tsn/xilinx_tsn.h  |  15 ++
> >   .../net/ethernet/xilinx/tsn/xilinx_tsn_ep.c   | 152 ++++++++++++++++++
> >   .../net/ethernet/xilinx/tsn/xilinx_tsn_main.c |   3 +
> >   4 files changed, 171 insertions(+), 1 deletion(-)
> >   create mode 100644 drivers/net/ethernet/xilinx/tsn/xilinx_tsn.h
> >   create mode 100644 drivers/net/ethernet/xilinx/tsn/xilinx_tsn_ep.c
> >
> > diff --git a/drivers/net/ethernet/xilinx/tsn/Makefile b/drivers/net/ethernet/xilinx/tsn/Makefile
> > index 6f99226f3dc8..5886828b386f 100644
> > --- a/drivers/net/ethernet/xilinx/tsn/Makefile
> > +++ b/drivers/net/ethernet/xilinx/tsn/Makefile
> > @@ -1,2 +1,2 @@
> >   obj-$(CONFIG_XILINX_TSN) += xilinx_tsn.o
> > -xilinx_tsn-y := xilinx_tsn_main.o
> > +xilinx_tsn-y := xilinx_tsn_main.o xilinx_tsn_ep.o
> > diff --git a/drivers/net/ethernet/xilinx/tsn/xilinx_tsn.h b/drivers/net/ethernet/xilinx/tsn/xilinx_tsn.h
> > new file mode 100644
> > index 000000000000..b0757e22d1fd
> > --- /dev/null
> > +++ b/drivers/net/ethernet/xilinx/tsn/xilinx_tsn.h
> > @@ -0,0 +1,15 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * AMD/Xilinx TSN Endpoint Ethernet MAC driver, shared definitions.
> > + *
> > + * Copyright (C) 2026 Advanced Micro Devices, Inc.
> > + */
> > +
> > +#ifndef _XILINX_TSN_H
> > +#define _XILINX_TSN_H
> > +
> > +#include <linux/platform_device.h>
> > +
> > +extern struct platform_driver xlnx_tsn_ep_driver;
> > +
> > +#endif /* _XILINX_TSN_H */
> > diff --git a/drivers/net/ethernet/xilinx/tsn/xilinx_tsn_ep.c b/drivers/net/ethernet/xilinx/tsn/xilinx_tsn_ep.c
> > new file mode 100644
> > index 000000000000..9b556edf5423
> > --- /dev/null
> > +++ b/drivers/net/ethernet/xilinx/tsn/xilinx_tsn_ep.c
> > @@ -0,0 +1,152 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * AMD/Xilinx TSN Endpoint MAC driver.
> > + *
> > + * Copyright (C) 2026 Advanced Micro Devices, Inc.
> > + */
> > +
> > +#include <linux/etherdevice.h>
> > +#include <linux/ethtool.h>
> > +#include <linux/if_ether.h>
> > +#include <linux/kernel.h>
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/module.h>
> > +#include <linux/netdevice.h>
> > +#include <linux/of.h>
> > +#include <linux/of_net.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/string.h>
> > +#include <linux/types.h>
> As for patch #2: Please drop <linux/mod_devicetable.h>.
>
> Best regards
> Uwe

Sure,  Will update in V2 series.

Thanks

Srinivas Neeli