Re: [PATCH net-next v4 1/4] dt-bindings: mfd: x-powers: Add AC200

[Andrew Lunn]

> +description:
> +  The AC200 is a mixed-signal companion IC containing audio, video, RTC and
> +  Fast Ethernet PHY functions. Its control registers are accessed over I2C.
> +
> +properties:
> +  compatible:
> +    const: x-powers,ac200
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +    description:
> +      AC200 input clock. When using the Ethernet PHY, its configured rate must
> +      be 24 or 27 MHz, matching the rates encoded by the documented EPHY clock
> +      selector.

What is the scope of this clock. Is the PHY the only consumer?

> +  ephy-vcc-supply:
> +    description: 3.3 V supply for the Ethernet PHY analog front end

This sounds to be specific to the PHY, so the PHY driver should be the
consumer, not the MFD as a whole. That then would allow the PHY to
perform power management, turn the regulator off when the link is
admin down, so suspended.

	Andrew