[PATCH] coccinelle: scripts: coccinelle: devm_free: reduce false positives
From: Julia Lawall
Date: Sun Aug 09 2026 - 12:55:14 EST
False positives could be introduced due to allocations using the new
_obj functions. Add these to the "safe" rule accordingly.
False positives could also be introduced when the same variable
name has two possible types. Incorporate type informationt to avoid
reporting this case This does lead to false negatives when no type
information is available.
Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxxx>
Reported-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
---
scripts/coccinelle/free/devm_free.cocci | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/scripts/coccinelle/free/devm_free.cocci b/scripts/coccinelle/free/devm_free.cocci
index 0880729ba..947d7e685 100644
--- a/scripts/coccinelle/free/devm_free.cocci
+++ b/scripts/coccinelle/free/devm_free.cocci
@@ -26,7 +26,8 @@ virtual report
virtual context
@r depends on context || org || report@
-expression x;
+type T;
+T x;
@@
(
@@ -56,18 +57,26 @@ expression x;
)
@safe depends on context || org || report exists@
-expression x;
+r.T x;
position p;
@@
(
x = kmalloc(...)
+|
+ x = kmalloc_obj(...)
+|
+ x = kmalloc_objs(...)
|
x = kvasprintf(...)
|
x = kasprintf(...)
|
x = kzalloc(...)
+|
+ x = kzalloc_obj(...)
+|
+ x = kzalloc_objs(...)
|
x = kmalloc_array(...)
|
@@ -105,7 +114,7 @@ position p;
)
@pb@
-expression r.x;
+r.T r.x;
position p != safe.p;
@@