Re: [PATCH net-next v11 02/12] net: phylink: introduce internal phylink PCS handling

From: Andrew Lunn

Date: Sun Aug 09 2026 - 13:26:22 EST


> +++ b/drivers/net/phy/phylink.c
> @@ -60,6 +60,9 @@ struct phylink {
> /* The link configuration settings */
> struct phylink_link_state link_config;
>
> + /* List of available PCS */
> + struct list_head pcs_list;
> +
> /* What interface are supported by the current link.
> * Can change on removal or addition of new PCS.
> */
> @@ -154,6 +157,8 @@ static const phy_interface_t phylink_sfp_interface_preference[] = {
>
> static DECLARE_PHY_INTERFACE_MASK(phylink_sfp_interfaces);
>
> +static void phylink_run_resolve(struct phylink *pl);

forward definitions are not liked. Please add a patch which moves it
earlier.

Andrew