Re: [PATCH v5 0/4] iio: accel: mma8452: use modern coding style and resource cleanup
From: Jonathan Cameron
Date: Sun Aug 09 2026 - 20:03:37 EST
On Sat, 08 Aug 2026 22:28:12 +0530
Sanjay Chitroda via B4 Relay <devnull+sanjayembeddedse.gmail.com@xxxxxxxxxx> wrote:
> Hi all,
>
> This series contains a nuber of small fixes, cleanup and improvements
> for the mma8452 accelerometer driver.
>
> The changes modernize macro like mutex with guard(), bulk regulator,
> IIO_DEV_ACQUIRE_DIRECT_MODE() and etc.
>
Applied to the testing branch of iio.git. Note that branch will be
rebased on rc1 once available in about 3 weeks time (and maybe
I'll rebase on intermediate baselines in between).
Thanks,
Jonathan
> Changes in v5:
> - Drop the PM runtime handling patch, as suitable hardware is not
> available to properly validate the PM state transitions.
> - Apply reviewed tags.
> - Rebase series onto the latest iio/testing branch.
> - Link to v4: https://patch.msgid.link/20260602-15-apr-pm-iio-mma8452-v4-temp-v4-0-26d6dff8fc55@xxxxxxxxx
> Changes in v4:
> - Part of the series already merged into the IIO tree; rebase the
> remaining patches onto the latest iio/testing branch.
> - Link to v3: https://lore.kernel.org/all/20260602-15-apr-pm-iio-mma8452-v4-temp-v4-0-26d6dff8fc55@xxxxxxxxx
> Changes in v3:
> - Following input from Andy and Jonathan added new changes as following
> 0001: handle return value to have proper error propagation
> 0002: use non-devm API to maintain resource management LIFO order
> 0006: convert individual regulator using bulk regulator API
> 0009: use IIO cleanup helper for DIRECT_MODE
> - Address kernel coding stype specific review comment
> - Reorder local struct device and dev_err_probe change
> v2 series -> https://lore.kernel.org/all/20260422165643.2148195-1-sanjayembedded@xxxxxxxxx/
> Changes in v2:
> - 0005: address review comment from Andy and Geert
> and use DEFINE_RUNTIME_DEV_PM_OPS macro
> - Added new cleanup channges in mma8452 driver
>
> No functional behavior changes are intended.
>
> Testing:
> - Compiled with W=1
> - Build-tested on QEMU x86_64
>
> Feedback and reviews are very welcome.
>
> ---
> Sanjay Chitroda (4):
> iio: accel: mma8452: convert to bulk regulator usage
> iio: accel: mma8452: use local struct device
> iio: accel: mma8452: Use IIO cleanup helpers
> iio: accel: mma8452: use guard() to release mutexes
>
> drivers/iio/accel/mma8452.c | 145 +++++++++++++++++---------------------------
> 1 file changed, 54 insertions(+), 91 deletions(-)
> ---
> base-commit: 350d1fb9204b13c5f95e511e98b8bcb47574d425
> change-id: 20260601-15-apr-pm-iio-mma8452-v4-temp-e040489abec3
>
> Best regards,
> --
> Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
>
>