Re: [PATCH 4/4] watchdog: aspeed: Propagate errors from optional IRQ lookup

[Guenter Roeck]

On 8/9/26 19:38, Bui Duc Phuc wrote:
> Hi Guenter,
>
> Thank you for your review.
>
> > > +             if (irq < 0 && irq != -ENXIO)
> > > +                     return irq;
> > >                if (irq > 0) {
> >
> > This if () is no longer needed.
>
> If we remove the if (irq > 0) check, irq can be -ENXIO and would be
> passed to devm_request_irq().
> I see that the irq argument of devm_request_irq() is an unsigned int.
> Would it be safe to pass -ENXIO to it in this case?
No, sorry, I was wrong.

Guenter