Re: [PATCH v7 1/3] dt-bindings: clock: cs2600: Add support for the CS2600

[Krzysztof Kozlowski]

On Fri, Aug 07, 2026 at 04:54:04PM +0100, Richard Fitzgerald wrote:
> diff --git a/Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml b/Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml
> new file mode 100644
> index 000000000000..630be30c160c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/cirrus,cs2600.yaml
> @@ -0,0 +1,170 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/cirrus,cs2600.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cirrus Logic Fractional-N Clock Synthesizer & Clock Multiplier
> +
> +maintainers:
> +  - patches@xxxxxxxxxxxxxxxxxxxxx

No group mailboxes are accepted. List here people which we can actually
contact.

I did not notice this in v5.


...

> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      clock-controller@2c {
> +        compatible = "cirrus,cs2600";
> +        reg = <0x2c>;
> +        #clock-cells = <1>;
> +        clocks = <&xtl_clk>, <&sync_clock>;
> +        clock-names = "ref_clk_in", "clk_in";
> +        vdd-supply = <&vreg>;
> +        cirrus,smart-mode;
> +        cirrus,smart-mode-clkin-only;
> +      };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4a8b0fd665ce..c2328066fede 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6213,6 +6213,13 @@ F:	sound/hda/codecs/side-codecs/cs*
>  F:	sound/hda/codecs/side-codecs/hda_component*
>  F:	sound/soc/codecs/cs*
>  
> +CIRRUS LOGIC CLOCK DRIVERS
> +M:	patches@xxxxxxxxxxxxxxxxxxxxx

Company drop boxes are not really working for us. I understand it does
work for you, though, but that's not what we want. Please come up with
list of people REALLY responsible for this.

Otherwise why would we want it in the Linux kernel?

> +L:	patches@xxxxxxxxxxxxxxxxxxxxx
> +S:	Supported
> +F:	Documentation/devicetree/bindings/clock/cirrus,cs2600*
> +F:	include/dt-bindings/clock/cirrus,cs2600*
> +
>  CIRRUS LOGIC HAPTIC DRIVERS
>  M:	James Ogletree <jogletre@xxxxxxxxxxxxxxxxxxxxx>
>  M:	Fred Treven <fred.treven@xxxxxxxxxx>
> diff --git a/include/dt-bindings/clock/cirrus,cs2600-clock.h b/include/dt-bindings/clock/cirrus,cs2600-clock.h
> new file mode 100644
> index 000000000000..bde505e17813
> --- /dev/null
> +++ b/include/dt-bindings/clock/cirrus,cs2600-clock.h

Same filename as the binding.

Best regards,
Krzysztof