Re: [PATCH v3 6/6] riscv: dts: spacemit: Add CTF2301 on K3 CoM260

[Troy Mitchell]

> > +&pinctrl {
> > +	i2c6-1-cfg {
> I'd prefer to use the reference, keep it short & close to where it's used
>
>  &i2c6_1_cfg
>
> > +		i2c6-1-pins {
> > +			power-source = <3300>;
> > +		};
> > +	};
> > +};
> > +
> > +&i2c6 {
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&i2c6_1_cfg>;
> > +	status = "okay";
> > +
> > +	temperature-sensor@4c {
> > +		compatible = "sensylink,ctf2301";
> > +		reg = <0x4c>;
> > +	};
> > +};

My intention here was to keep all board-specific pin configuration
overrides under a single &pinctrl block, so that they can be found and
maintained in one place. Using a separate top-level reference for each pin
group would tend to scatter those overrides throughout the board DTS as
more groups are customized. The &pinctrl block is also placed immediately
before the &i2c6 consumer.

Would keeping the current structure be acceptable for that reason? If you
still prefer the direct reference, I will change it to &i2c6_1_cfg in the
next revision.

                                            - Troy

Attachment: signature.asc
Description: PGP signature