Re: [PATCH RFC v6 7/7] mfd: ls2kbmc: Capture the reset event of BMC through GPIO
From: Bartosz Golaszewski
Date: Mon Aug 10 2026 - 07:34:39 EST
On Mon, 10 Aug 2026 13:28:56 +0200, Miao Wang <shankerwangmiao@xxxxxxxxx> said:
> Hi,
>
>> 2026年8月10日 18:14,Bartosz Golaszewski <brgl@xxxxxxxxxx> 写道:
>>
>> On Tue, 4 Aug 2026 21:14:25 +0200, Miao Wang via B4 Relay
>> <devnull+shankerwangmiao.gmail.com@xxxxxxxxxx> said:
>>
>>> + gpio_dev_get_fwnode(gdev), LS2K_BMC_RESET_GPIO, GPIO_ACTIVE_HIGH);
>>
>> TBH this could become a GPIOLIB function as gpio_device_get_fwnode().
>
> I wonder if this function should be a static inline function defined
> in gpio/driver.h or a normal function defined in gpiolib.c? I tend
> to the former.
>
Yes, a regular GPL exported function in gpiolib.c please.
Bartosz