Re: [PATCH 6/6] mm/swap: rename __swap_writepage() to __swap_writeout()

[Lorenzo Stoakes (ARM)]

On Fri, Aug 07, 2026 at 10:44:31PM +0300, Tal Zussman wrote:
> On 8/7/26 1:01 PM, Johannes Weiner wrote:
> > On Thu, Aug 06, 2026 at 06:55:38PM -0400, Tal Zussman wrote:
> >> Commit 84798514db50 ("mm: Remove swap_writepage() and
> >> shmem_writepage()") renamed swap_writepage() to swap_writeout().  Rename
> >> __swap_writepage(), which operates on a folio, to match its caller.
> >> Update a stale reference to swap_writepage() in swapfile.c as well.
> >>
> >> Signed-off-by: Tal Zussman <tz2294@xxxxxxxxxxxx>
> >
>
> Thanks for the reviews!
>
> > Looking at that commit, I can only guess that pageout() had an
> > influence on the swap_writeout() name.
> >
> > However, on the read side of the page_io.c API, we're following
> > swap_read_folio* consistently.
> >
> > [__]swap_write_folio* would seem more symmetrical?
> >
>
> That sounds reasonable, will change it.
>
> > [ At the risk of starting something, should the file itself be
> >    renamed? swap_rw.c or swap_io.c or something. ]
> >
>
> You said it, not me... :)
> I like swap_io.c - happy to stick a patch at the beginning renaming it
> if there are no objections.

folio_io.c! ;) Kidding, swap_io.c seems reasonable, feel free to rename it.

You should also update the entry in MAINTAINERS too.

--
Cheers, Lorenzo