Re: [PATCH RFC v8 0/8] mfd: ls2kbmc: multiple fixes for this driver

From: Bartosz Golaszewski

Date: Mon Aug 10 2026 - 10:31:15 EST


On Mon, 10 Aug 2026 15:20:47 +0200, Miao Wang <shankerwangmiao@xxxxxxxxx> said:
> Hi,
>
>> 2026年8月10日 21:08,Bartosz Golaszewski <brgl@xxxxxxxxxx> 写道:
>>
>> On Mon, Aug 10, 2026 at 3:04 PM Miao Wang via B4 Relay
>> <devnull+shankerwangmiao.gmail.com@xxxxxxxxxx> wrote:
>>>
>>> ---
>>> Changes in v8:
>>> - Address issues found by the Sashiko AI review bot
>>> - Fix the error path of the probe function, preventing unintentionally
>>> returning 0 on failure
>>> - Reorder the patches in the series to make the change to the Kconfig
>>> entry for ls2kbmc to be the last patch, to satisfy the AI bot's
>>> concern on failure to clean up when the driver is built as a module
>>> and is being removed.
>>> - Link to v7: https://lore.kernel.org/r/20260810-ls2kbmc-mod-v7-0-8aa0fb5a5462@xxxxxxxxx
>>>
>>
>> Don't send several versions of the same big series within minutes of
>> each other. Give reviewers time to respond.
>
> Sorry for bothering the maintainers. A reviewer previously required
> a clean or justified Sashiko pass first before reviewing and thus I
> have to fix the high issues found by the bot. I would be nice if I
> can privately send patches to the bot and let it review before I
> send it publicly, to reduce the disturbance to other maintainers.
> I tried to run that bot locally but failed because the bot was
> consuming too many tokens before generating a final result.
>

That doesn't change anything. Sashiko commented on v7 which also contained
changes requested by me. You should wait until I respond before resending the
series with sashiko issues fixed because I may possibly have more comments too.

Bart