Re: [PATCH v4 3/4] liveupdate: luo_session: include linux/mm.h for virt/phys translation

[Pratyush Yadav]

On Mon, Aug 10 2026, Huacai Chen wrote:

> Hi, George,
>
> This should be the 2nd patch.

Agreed.

With that done,

Reviewed-by: Pratyush Yadav <pratyush@xxxxxxxxxx>

>
> Huacai
>
> On Fri, Aug 7, 2026 at 6:39 PM George Guo <dongtai.guo@xxxxxxxxx> wrote:
>>
>> From: George Guo <guodongtai@xxxxxxxxxx>
>>
>> luo_session.c calls virt_to_phys() and phys_to_virt(). On LoongArch with
>> CONFIG_KFENCE=y, these macros (in arch/loongarch/include/asm/io.h) expand
>> to offset_in_page() and page_address(), both declared in <linux/mm.h>.
>>
>> Since luo_session.c only includes <linux/io.h>, the translation unit fails
>> to build with CONFIG_KFENCE=y:
>>
>>   asm/io.h: error: implicit declaration of function 'offset_in_page'
>>   asm/io.h: error: implicit declaration of function 'page_address'
>>
>> Add the missing include to fix these build errors.
>>
>> Co-developed-by: Kexin Liu <liukexin@xxxxxxxxxx>
>> Signed-off-by: Kexin Liu <liukexin@xxxxxxxxxx>
>> Signed-off-by: George Guo <guodongtai@xxxxxxxxxx>
>> Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
>> ---
>>  kernel/liveupdate/luo_session.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c
>> index f38b5b18f3f8..31490ac7b63d 100644
>> --- a/kernel/liveupdate/luo_session.c
>> +++ b/kernel/liveupdate/luo_session.c
>> @@ -94,6 +94,7 @@
>>  #include <linux/kho/abi/luo.h>
>>  #include <linux/list.h>
>>  #include <linux/liveupdate.h>
>> +#include <linux/mm.h>
>>  #include <linux/mutex.h>
>>  #include <linux/rwsem.h>
>>  #include <linux/slab.h>
>> --
>> 2.53.0
>>
>>

-- 
Regards,
Pratyush Yadav