Re: [PATCH net-next v8 14/17] net: macb: move printk() calls out of bp->lock critical section

From: Jakub Kicinski

Date: Mon Aug 10 2026 - 20:09:03 EST


On Wed, 05 Aug 2026 19:42:43 +0200 Théo Lebrun wrote:
> printk() while bp->lock is acquired is dangerous if netconsole is active
> on the interface. In that setup, we might land in macb_poll_controller()
> -> macb_interrupt() -> spin_lock(&bp->lock) but bp->lock is already
> acquired.

Reportedly this patch adds:

drivers/net/ethernet/cadence/macb_main.c: In function ‘macb_interrupt_misc’:
drivers/net/ethernet/cadence/macb_main.c:2130:28: warning: variable ‘netdev’ set but not used [-Wunused-but-set-variable=]
2130 | struct net_device *netdev;
| ^~~~~~

which persists after the series.
--
pw-bot: cr