Re: [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
From: Uwe Kleine-König
Date: Tue Aug 11 2026 - 01:09:39 EST
Hello,
On Wed, Jun 03, 2026 at 07:09:09PM +0300, Francis Laniel wrote:
> All types in `bindings` implement `Zeroable` if they can, so use
> `pin_init::zeroed` instead of relying on `unsafe` code.
>
> If this ends up not compiling in the future, something in bindgen or on
> the C side changed and is most likely incorrect.
>
> Suggested-by: Benno Lossin <lossin@xxxxxxxxxx>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Acked-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
> Signed-off-by: Francis Laniel <laniel_francis@xxxxxxxxxxxxxxxxxxx>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
for the 7.3 merge window.
b4 behaved strange on that patch:
$ b4 am -s -l -t -3 20260603160910.159307-1-laniel_francis@xxxxxxxxxxxxxxxxxxx
Grabbing thread from lore.kernel.org/all/20260603160910.159307-1-laniel_francis@xxxxxxxxxxxxxxxxxxx/t.mbox.gz
Analyzing 2 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 23 code-review messages
Checking attestation on all messages, may take a moment...
---
✓ [PATCH v3] rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
+ Link: https://patch.msgid.link/20260603160910.159307-1-laniel_francis@xxxxxxxxxxxxxxxxxxx
+ Signed-off-by: Uwe Kleine-König <ukleinek@xxxxxxxxxx>
---
✓ Signed: DKIM/privacyrequired.com
---
Total patches: 1
---
NOTE: some trailers ignored due to from/email mismatches:
! Trailer: Suggested-by: Benno Lossin <lossin@xxxxxxxxxx>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
! Trailer: Acked-by: Michal Wilczynski <m.wilczynski@xxxxxxxxxxx>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
! Trailer: Signed-off-by: Francis Laniel <laniel_francis@xxxxxxxxxxxxxxxxxxx>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
! Trailer: Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Msg From: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
NOTE: Rerun with -S to apply them anyway
Preparing fake-am for v3: rust: pwm: replace `core::mem::zeroed` with `pin_init::zeroed`
range: 2707b9df955d..81c3f2b030a1
Preared a fake commit range for 3-way merge (2707b9df955d..81c3f2b030a1)
---
Link: https://patch.msgid.link/20260603160910.159307-1-laniel_francis@xxxxxxxxxxxxxxxxxxx
Base: applies clean to current tree
git checkout -b v3_20260603_laniel_francis_privacyrequired_com HEAD
git am -3 ./v3_20260603_laniel_francis_rust_pwm_replace_core_mem_zeroed_with_pin_init_zeroed.mbx
I didn't research what went wrong there and the trailer made it into the
patch anyhow and adding -S doesn't change the patch. I added the
tools@k.o mailing list to Cc:, maybe someone there wants to debug that.
Best regards and thanks for your contribution,
Uwe
Attachment:
signature.asc
Description: PGP signature