Re: [PATCH v5 4/4] iio: light: veml6031x00: add support for events and trigger

From: Andy Shevchenko

Date: Tue Aug 11 2026 - 01:42:57 EST


On Tue, Aug 11, 2026 at 01:09:29AM +0200, Javier Carrasco wrote:
> On Mon Aug 10, 2026 at 5:32 PM CEST, Andy Shevchenko wrote:
> > On Fri, Aug 07, 2026 at 03:51:55PM +0200, Javier Carrasco wrote:

...

> >> +static int veml6031x00_set_interrupt(struct veml6031x00_data *data, bool state)
> >> + __must_hold(&data->irq_lock)
> >
> > The sparse annotations is fine, but lockdep one is even better.
>
> I have seen a few instances in a number of subsystems where both are used
> at the same time. What is the preferred alternative here?

Both. lockdep is a runtime check, sparse one is a build-time.

--
With Best Regards,
Andy Shevchenko