Re: [PATCH net-next v5 1/5] dt-bindings: mfd: x-powers: Add AC200
From: Krzysztof Kozlowski
Date: Tue Aug 11 2026 - 03:21:01 EST
On 09/08/2026 22:28, James Hilliard wrote:
> The AC200 is an I2C-controlled mixed-signal companion IC containing
> audio, video, RTC and Fast Ethernet PHY functions.
>
> Describe the parent device and its shared input clock. The Ethernet PHY
> is represented by a PHY package on its MDIO bus, with a phandle back to
> this device for access to the package control registers, so it does not
> require an MFD child node. Function-specific supplies belong to their
> consumer bindings rather than the shared parent.
>
> The input clock must run at 24 or 27 MHz when the Ethernet PHY is used,
> matching the rates encoded by its documented clock selector.
>
> Signed-off-by: James Hilliard <james.hilliard1@xxxxxxxxx>
> ---
I do not understand why MFD and net are combined. And nothing in top
part of cover letter explains me that (which I asked already - any
dependency or merging is THE MOST important information. Where do you
put the most important information which maintainers should see
immediately?)
Bundling it together suggests this is somehow incomplete and later will
be finished, which is wrong by itself. How to fix it - decouple
dependencies.
Best regards,
Krzysztof